Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor pointer not showing when toggleMask is active #17510

Open
4 tasks
navedqb opened this issue Jan 28, 2025 · 1 comment · May be fixed by #17511
Open
4 tasks

Cursor pointer not showing when toggleMask is active #17510

navedqb opened this issue Jan 28, 2025 · 1 comment · May be fixed by #17511
Labels
Component: Theme Issue or pull request is related to Theme Status: Discussion Issue or pull request needs to be discussed by Core Team
Milestone
19.1.0

Comments

@navedqb
Copy link
Contributor

navedqb commented Jan 28, 2025 •
edited
Loading

Describe the bug

Password: Hand/Pointer icon not displayed while hovering over the eye icon in password ToggleMask mode

Pull Request Link

#17511

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/password#togglemask

Environment

Windows

Angular version

19.x.x

PrimeNG version

v19

Node version

20.9.0

Browser(s)

Chrome

Steps to reproduce the behavior

https://primeng.org/password#togglemask

Expected behavior

Should show hand/cursor icon on hovering over.
@navedqb navedqb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 28, 2025
@navedqb navedqb linked a pull request Jan 28, 2025 that will close this issue
Open
@ThomOrlo
Copy link

This might be a bad idea, the cursor pointer should only be used for links.

Sources :

@mertsincan mertsincan added Status: Discussion Issue or pull request needs to be discussed by Core Team Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
@mertsincan mertsincan moved this from Review to Theme in PrimeNG Jan 29, 2025
This was referenced Jan 29, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Theme Issue or pull request is related to Theme Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
PrimeNG
Status: Theme
Milestone
19.1.0
Development

Successfully merging a pull request may close this issue.

Fix: show cursor pointer on toggle mask qburst/primeng-1
3 participants
@ThomOrlo @mertsincan @navedqb