Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog: No way to distinguish reject and close button action being fired #17512

Open
1 of 4 tasks
majkers opened this issue Jan 28, 2025 · 1 comment
Open
1 of 4 tasks
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Milestone

Comments

@majkers
Copy link

majkers commented Jan 28, 2025

Describe the bug

I've just updated to primeNG 19 from 17. I've noticed that close method from confirmDialog is not being fired since confirmDialog uses dialog internally. And that is why now there is no way to distinguish between reject and close button being fired. It was working ok in primeNG 17 version.
As a reproducer You can check showcase and basic confirmDialog on https://primeng.org/confirmdialog You can see subscribing to reject never fires with close event. Some time ago it was possible like that: #3428 (comment)

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/confirmdialog

Environment

N/A

Angular version

19.1.3

PrimeNG version

v19

Node version

20.18.1

Browser(s)

All

Steps to reproduce the behavior

  1. Go to https://primeng.org/confirmdialog
  2. Choose basic confirmDialog
  3. Click close icon
  4. Nothing happening besides dialog is being hidden....

Expected behavior

I expect to fire reject event with ConfirmEventType.CANCEL as close method in confirmdialog.ts states

@majkers majkers added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 28, 2025
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2025
@mertsincan mertsincan added this to the Future milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
Copy link

Due to PrimeTek's demanding roadmap for PrimeNG, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Help Wanted Issue or pull request requires extra help and feedback
Projects
Status: Review
Development

No branches or pull requests

2 participants