Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase, Table: Use TableLazyLoadEvent instead of LazyLoadEvent #17515

Closed
4 tasks
can-oezkan opened this issue Jan 28, 2025 · 0 comments · Fixed by #17516
Closed
4 tasks

Showcase, Table: Use TableLazyLoadEvent instead of LazyLoadEvent #17515

can-oezkan opened this issue Jan 28, 2025 · 0 comments · Fixed by #17516
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@can-oezkan
Copy link
Contributor

Describe the bug

The correct type for the onLazyLoad() event is TableLazyLoadEvent.

Showcase still uses LazyLoadEvent which throws a compile error when strictTemplates is enabled in tsconfig.json.

It looks like LazyLoadEvent is never really used anymore and should be removed. I have not removed it in my PR as this would be a breaking change.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/table#virtual-scroll-lazy

Environment

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Expected behavior

The correct type should be used.

@can-oezkan can-oezkan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 28, 2025
@mertsincan mertsincan added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2025
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants