Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal component docs suggest non-existent commands #17519

Open
1 of 4 tasks
zachary-svoboda-accesso opened this issue Jan 28, 2025 · 0 comments
Open
1 of 4 tasks

Terminal component docs suggest non-existent commands #17519

zachary-svoboda-accesso opened this issue Jan 28, 2025 · 0 comments
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@zachary-svoboda-accesso

Describe the bug

Terminal component documentation suggests the following:

Enter "date" to display the current date, "greet {0}" for a message and "random" to get a random number.

While the date command works, the greet and random ones do not. Looking through the code history, it seems this was never the case.

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

Unfortunately company policy does not allow me to contribute open source code for issues not directly relevant to my work. We are not using the terminal component so I cannot argue that successfully

Reproducer

https://primeng.org/terminal#basic

Environment

PrimeNG Docs Website

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

Firefox 134

Steps to reproduce the behavior

  1. Scroll to the terminal visible at https://primeng.org/terminal#basic
  2. Type "random" and press enter
  3. Type "greet {0}" and press enter
  4. Note the "Unknown Command" message in each case

Expected behavior

Either the message should be updated to remove those non-existent suggestions or they should be implemented in the component code to work as suggested

@zachary-svoboda-accesso zachary-svoboda-accesso added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 28, 2025
@mertsincan mertsincan added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2025
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
@cagataycivici cagataycivici moved this from Review to Theme in PrimeNG Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Theme
Development

No branches or pull requests

3 participants