Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showOtherMonths styling does not work #7222

Closed
annesophien opened this issue Feb 8, 2019 · 1 comment
Closed

showOtherMonths styling does not work #7222

annesophien opened this issue Feb 8, 2019 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@annesophien
Copy link

Current Waiting Time: ~8 weeks.

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
Please demonstrate your case at stackblitz by using the issue template below. Issues without a test case have much less possibility to be reviewd in detail and assisted.

https://stackblitz.com/github/primefaces/primeng-issue-template

Current behavior
Per the PrimeNG documentation, showOtherMonths should by default be set to true, then when we select a day at the beginning or end of the month, we should be able to see the selected date highlighted in the next month. However in the documentation, when we select 2/27/2019 and navigate to March, we don't see that 2/27 is selected.

When I manually set showOtherMonths to true, it still does not show the previous month's selected day as selected in the next month.

We can see in the calendar.ts component that it expects css classes ui-datepicker-other-month, ui-datepicker-current-day, or ui-datepicker-today, but if you check calendar.css, there are no such classes.

Expected behavior
We should be able to see the previous date selected in the next/previous month like in PrimeNG v5.

Minimal reproduction of the problem with instructions
PrimeNG v5 calendar documentation (Correct Behavior):
https://www.primefaces.org/primeng-5.2.7/#/calendar
image

PrimeNG v7 calendar documentation (Wrong Behavior): https://www.primefaces.org/primeng/#/calendar
image

What is the motivation / use case for changing the behavior?
p-calendar in v6 and v7 should work like in v5.

  • Angular version: 6.0

  • PrimeNG version: 6.0 and 7.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Chrome, IE

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    TypeScript

@ranjitkumarsingh
Copy link

ranjitkumarsingh commented Feb 18, 2019

+1, any idea when this can be fixed?

@yigitfindikli yigitfindikli self-assigned this Feb 24, 2019
@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Feb 24, 2019
@cagataycivici cagataycivici changed the title showOtherMonths does not work in PrimeNG v6 and v7 showOtherMonths styling does not work Feb 27, 2019
@cagataycivici cagataycivici added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Feb 27, 2019
@cagataycivici cagataycivici added this to the 7.1.0 milestone Feb 27, 2019
darkhelmet pushed a commit to weknowtraining/primeng that referenced this issue Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants