Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: WeekNumber looks like it is selectable #9746

Closed
Timmeeeey opened this issue Jan 11, 2021 · 0 comments
Closed

Calendar: WeekNumber looks like it is selectable #9746

Timmeeeey opened this issue Jan 11, 2021 · 0 comments
Assignees
@yigitfindikli
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
11.3.0-Final

Comments

@Timmeeeey
Copy link

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] support request

Current behavior
When you hover over the weekNumber in Calendar it behaves like it is selectable (gray background and cursor: pointer).
image

Expected behavior
The weekNumber should be disabled like the weekNumber header.
Then they are less likely to be confused with the actual dates.
image

You just have to add the class p-disabled in addition to p-datepicker-weeknumber.

primeng/src/app/components/calendar/calendar.ts

Line 83 in 0c510bf

<td *ngIf="showWeek" class="p-datepicker-weeknumber">

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 12, 2021
@yigitfindikli yigitfindikli added this to the 11.2.0 milestone Jan 12, 2021
@yigitfindikli yigitfindikli self-assigned this Jan 12, 2021
@yigitfindikli yigitfindikli modified the milestones: 11.2.0, 11.3.0 Jan 21, 2021
This was referenced Mar 15, 2021
Merged
Closed
@yigitfindikli yigitfindikli added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Mar 15, 2021
@yigitfindikli yigitfindikli added LTS-FIXED-10.1.1 and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
11.3.0-Final
Development

No branches or pull requests
2 participants
@yigitfindikli @Timmeeeey