Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to add Videos to the Hero. #601

Open
joshvogel17 opened this issue Jun 4, 2024 · 0 comments
Open

[Feature Request] Ability to add Videos to the Hero. #601

joshvogel17 opened this issue Jun 4, 2024 · 0 comments

Comments

@joshvogel17
Copy link

Proposal
There is a need to display videos in the Hero given a url for the video source. The video would be located in the same place as the Hero.Image and follow the same positioning logic. A Hero could only have an image or a video. If a Hero is given both, the Hero.Image would take priority.

Possible Solution
Create a Hero.Video component that has videoSrc as a parameter. The Hero.Video would be placed in the same Grid.Column as the Hero.Image so that it would adhere to the imagePosition logic.

Only render the Hero.Video if there is no Hero.Image component.

Example Video in Hero

Image

@raytalks raytalks added the brand label Jun 14, 2024
@rezrah rezrah added the swp label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants