Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modification Request] Add support to display pillars as cards #816

Open
seangolob opened this issue Nov 13, 2024 · 1 comment
Open

[Modification Request] Add support to display pillars as cards #816

seangolob opened this issue Nov 13, 2024 · 1 comment

Comments

@seangolob
Copy link

Hi PB team!

I have noticed several pages in production where there have been custom styles applied to make pillars look like cards.

Image

Currently, custom styles are applied to the Pillar wherever they are implemented to make them look like cards. Should this be a feature that is supported by Primer Brand so we can get consistency for these use cases?

Thank you for your fantastic work! 🙇

@danielguillan
Copy link
Contributor

danielguillan commented Nov 14, 2024

Hey Sean!

Thanks for bringing this up and for sharing all those references. Adding a background to pillars is definitely becoming a common pattern.

Historically, we aimed to create a visual distinction between Cards and Pillars by only adding a background to Cards. This approach clarifies that Cards are interactive elements, while Pillars are pirmarily static content. One key distinction is that Cards always link to another location, making the entire element clickable. In contrast, Pillars may have optional links, with only the link being clickable. A common feature of all the Pillar examples you've shared is that none include a link, which seems enough to reinforces this distinction.

Therefore, we might consider allowing a background for Pillars, but perhaps only when there is no link? @rezrah @jesussandreas, I would love to hear your thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants