Release Tracking

[github-actions]

This is a scheduled issue for tracking the release between Monday 24th and Friday 28th

Last week	Value
Issue	Release Tracking
Conductor	broccolinisoup
Release Pull Request	Link
Integration tests	Link

Timeline

• Monday, July 24th
• Tuesday, July 25th
• Wednesday, July 26th
  • Sync with @broccolinisoup on release from last week
  • Waiting on the following PRs to be merged to address issues:
    • UnderlineNav2: Take the listing html structure back to its original state #3559
    • [⏪ Reverted] fix(PageLayout): Remove warning for the deprecated position prop #3545
    • https://github.com/github/github/pull/281921
• Thursday, July 27th
  • Revert PR that was intended for next-major but was merged into main Revert "Upgrade styled-components to v5" #3567
• Friday, July 28th
  • It seems like the release workflow got confused around releases due to the inclusion of a major changelog which caused it not to include the latest changes in the current @next tag 🤔
  • Given the lag in getting this release out, I vote for locking main until we can address the issues in the release

Checklist

• Checks have passed on the integration Pull Request downstream
• Release tracking Pull Request has been merged
• Stable release available on npm
• Downstream repos have been updated to latest

Notes

Debugging notes for Switch change

• There seems to be an incorrect aria-labelledby in SystemSettings, specifically in ToggleBox there may not be a label available
• There seems to be a "unique key" warning with respect to UnderlineNav in FileTree.test.tsx
  • It seems to be related to the listItems.map call that cannot infer a key because listItem.props.children is undefined
  • This value is undefined because OverviewRepoFiles does not use UnderlineNav > UnderlineNav.item, they have a wrapper OverviewFileTab that is what renders UnderlineNav.Item

[broccolinisoup]

These 2 PRs are merged and their related failings are gone in the integration PR as well ✨
#3559
#3545

https://github.com/github/github/pull/281921 → This PR is fixing some of the ToogleSwitch issues but there are still tests are failing on the memex side here. Once we fix the memex tests - it looks like we are gonna be good!

[siddharthkp]

Once we fix the memex tests - it looks like we are gonna be good!

Hurray! Going to focus on that first then!