New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Remove redundant ThemeProvider from tests #4514

Open

siddharthkp opened this issue Apr 19, 2024 · 1 comment

Labels

react size: sand

Member

siddharthkp commented Apr 19, 2024 •

edited

Loading

There are multiple tests that wrap the rendered component with ThemeProvider: https://github.com/search?q=repo%3Aprimer%2Freact+%3CThemeProvider+path%3Atest.tsx&type=code

We do not have to do this anymore because we already wrap all stories in a ThemeProvider in preview.js.

Note: There might be a couple exceptions so make sure to test this by switching themes in storybook

primer-issue-triage-primer bot added the react label

siddharthkp added the size: sand label

Member

lesliecdubs commented Aug 27, 2024

👋 What is the impact of the redundant ThemeProvider in tests? Is this a "nice-to-have" quality of life improvement?

siddharthkp added component: Banner and removed component: Banner labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment