Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Support a responsive value for isOpen #4755

Open
maximedegreve opened this issue Jul 19, 2024 · 2 comments
Open

Dialog: Support a responsive value for isOpen #4755

maximedegreve opened this issue Jul 19, 2024 · 2 comments
Labels

Comments

@maximedegreve
Copy link
Contributor

Description

In some cases you want to display data in a dialog on mobile but on desktop keep it on the page.
This is currently not possible with this component due to the lack of responsive support on the isOpen value.
Wrapping the dialog in a div and setting display: none on smaller breakpoints neither works.

Steps to reproduce

<Box sx={{ display: ['block', 'block', 'none'] }}>
     <Dialog title={TITLE} onClose={onClickClose}>test</Dialog
</Box>

Version

Latest

Browser

Safari

@maximedegreve maximedegreve added bug Something isn't working component: Dialog labels Jul 19, 2024
@maximedegreve maximedegreve changed the title Dialog v2: Support a responsive value for isOpen Dialog: Support a responsive value for isOpen Jul 19, 2024
@maximedegreve maximedegreve added enhancement New feature or request and removed bug Something isn't working labels Jul 19, 2024
@joshblack
Copy link
Member

Notes from Maintainer Sync (July 22nd)

Context from Slack: https://github.slack.com/archives/GACAW0NPM/p1721383080023129

We're going to leave this in the inbox this week while waiting for the conversation in Slack to resolve 👀

@lesliecdubs
Copy link
Member

Notes from Maintainer Sync (August 5th)

It might be a good idea to experiment / prototype how this would work, testing focus management, declarative buttons of a Dialog, etc.

We should revisit this in a future planning cycle to see if we can dedicate some time to the explorations mentioned. Please let us know if there is any urgency around this sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants