Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ActionMenu still scrolls if in sticky container #4780

Open
dipree opened this issue Jul 26, 2024 · 4 comments
Open

[Bug] ActionMenu still scrolls if in sticky container #4780

dipree opened this issue Jul 26, 2024 · 4 comments

Comments

@dipree
Copy link
Contributor

dipree commented Jul 26, 2024

Description

ActionMenu always has position: absolute. When in a container that is sticky it will consequently not stick with the container but with the absolute position. So, when scrolling it goes weeee 🚀

Showing the table of content of a readme in GitHub using an action menu, which is in a sticky container

Steps to reproduce

Put ActionMenu in a sticky container and scroll. For example, the table of content for the README in our repo https://github.com/github/primer, trigger the ActionMenu, than scroll.

Version

36.27.0

Browser

No response

@joshblack
Copy link
Member

Can confirm, when scrolling it goes weeee 🚀 (😂)

@dipree we were taking a look at this during our maintainer sync and wanted to check-in to understand where this issue came from (did you happen to see this yourself or was it user reported?)

We're trying to see where this fits among our issues in terms of priority 👀

@Akashgite1
Copy link

please assign to me

@dipree
Copy link
Contributor Author

dipree commented Aug 5, 2024

@dipree we were taking a look at this during our maintainer sync and wanted to check-in to understand where this issue came from (did you happen to see this yourself or was it user reported?)

It has been reported in the past for the mentioned README toc, but I'm not sure anymore where that was unfortunately. I was just recently reminded of this again when putting an ActionMenu in a sticky header.

@Akashgite1
Copy link

The behavior you're describing occurs because position: absolute positions the element relative to its nearest positioned ancestor. In a sticky container, if there's no such ancestor, the element will be positioned relative to the document, which can cause it to move unexpectedly when scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants