Avoided repetative calling of the customhook #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariharan-ingersal
changed the title
princefishthrower
requested changes
Oct 3, 2021
There was a problem hiding this comment.
Didn't see this until after writing my comment. Looks like a good start.
- Please reencapsulate the
const idinto this new variable - the variable value should toggle betweenundefinedand the Interval ID, and we shouldn't need aconst idanymore. - Let's use
LocalStorageinstead of the window object, since we are using it elsewhere now in the code andwindowis troublesome with TypeScript (with thoseas anys). - Finally, make sure the differences between dev and prod are employed - in dev this should throw a
new Error()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1 by using a varible
IS_TITLE_CHANGE_RUNNINGon windows object to track whether a title/favicon animation is already triggered or not.