Store external favicons in localStorage #6
Conversation
There was a problem hiding this comment.
This looks like a nice way to store them. I'd say you're nearly there. Now it's just a matter of setting the faviconRef.current.href to the base64 string you've stored. Keep in mind they should be merged back into the faviconURIs since it is possible for a user to mix both local and external favicon URIs. Can you try and add this? Also, what is draw the rest of the owl?
One small other thing. I think it's time we start creating util functions. Can you create a util folder under src and then a single file and export your convertToBase64 function from it? Also add the type annotation to externalFaviconURI, when you do so i.e. (externalFaviconURI: string) => ...
Let me know how it goes! This will be a great addition to the hook!
|
@princefishthrower thanks for the comment, I'll tackle the stuff you mentioned soon. Also the owl comment is from a stupid meme.. I didn't sleep much the night I wrote this lol |
|
@Gee19 haha I remember now 😂 I've seen that one! |
|
Still needs to be tested but I implemented the requested changes. |
|
Would you be open to formatting stuff with |
|
@Gee19 - did you at least smoke test it? Does it "work"? Feel free to add |
My initial pass was working when I tested it in isolation. I haven't been able to test the new changes. I'll come back to this tomorrow |
|
I don't believe this approach will work because of CORS :( |
🎃 work in progress but open to feedback
will hopefully resolve #2