Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bash scripts for prebuild with TS for Windows support #1346

Closed
ctrlc03 opened this issue Apr 4, 2024 · 2 comments · Fixed by #1372
Closed

Replace bash scripts for prebuild with TS for Windows support #1346

ctrlc03 opened this issue Apr 4, 2024 · 2 comments · Fixed by #1372
Labels
enhancement New feature or request

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Apr 4, 2024 •
edited
Loading

Currently, MACI relies on some bash scripts for prebuild activities, removing these will open up being supported on Windows.
@ctrlc03 ctrlc03 added this to MACI Apr 4, 2024
@ctrlc03 ctrlc03 converted this from a draft issue Apr 4, 2024
@ctrlc03 ctrlc03 added the enhancement New feature or request label Apr 4, 2024
@samajammin
Copy link
Member

Any thoughts on how to replace them?

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Apr 8, 2024

Any thoughts on how to replace them?

we could simply re-write the logic in typescript. The bash scripts really only just run a sequence of typescript scripts so shouldn't be too much effort

@0xmad 0xmad mentioned this issue Apr 12, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in MACI Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(contracts): get rid of bash scripts for prebuild command privacy-scaling-explorations/maci
2 participants
@samajammin @ctrlc03