Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple (and concurrent) Polls #1418

Closed
ctrlc03 opened this issue May 2, 2024 · 0 comments · Fixed by #1417
Closed

Allow multiple (and concurrent) Polls #1418

ctrlc03 opened this issue May 2, 2024 · 0 comments · Fixed by #1417
Assignees
Labels
enhancement New feature or request

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented May 2, 2024

Currently in MACI, it is not possible to re use the same Maci contract for multiple polls due to the AccQueue structure inner working. After a merge operation, the index would skip ahead to the smallest subtree capacity, and this would not be replicated offchain causing state root mismatches. As the modification would include quite some changes to the logic, and these structures might be removed soon from MACI, we should look into fixing this in another way.

A proposed solution is to use a LazyIMT structure https://github.com/privacy-scaling-explorations/zk-kit/blob/main/packages/imt.sol/contracts/LazyIMT.sol which is cheap to use and does not require any merge operation.

@ctrlc03 ctrlc03 added this to MACI May 2, 2024
@ctrlc03 ctrlc03 self-assigned this May 2, 2024
@ctrlc03 ctrlc03 converted this from a draft issue May 2, 2024
@ctrlc03 ctrlc03 added the enhancement New feature or request label May 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in MACI May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant