Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ensure that it's clear that num signups account for empty leaf #1571

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Jun 14, 2024

Description

Describe how to get the actual number of "real" users signed up for a maci poll.

Related issue(s)

fix #962

Confirmation

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Jun 17, 2024 7:14am

@ctrlc03 ctrlc03 self-assigned this Jun 14, 2024
@ctrlc03 ctrlc03 added the documentation Improvements or additions to documentation label Jun 14, 2024
Copy link
Collaborator

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! should we just add this info to the latest version doc? or also update docs of other versions? (since this issue exists in every version?)

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Jun 17, 2024

thanks! should we just add this info to the latest version doc? or also update docs of other versions? (since this issue exists in every version?)

good call, added to v1.2 docs too

@ctrlc03 ctrlc03 force-pushed the docs/clarify-num-signups branch from 772e85c to 23c3606 Compare June 17, 2024 07:10
@ctrlc03 ctrlc03 enabled auto-merge (squash) June 17, 2024 07:10
@ctrlc03 ctrlc03 force-pushed the docs/clarify-num-signups branch from 23c3606 to f310325 Compare June 17, 2024 07:11
@ctrlc03 ctrlc03 merged commit 2a8e02c into dev Jun 17, 2024
22 checks passed
@ctrlc03 ctrlc03 deleted the docs/clarify-num-signups branch June 17, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Clarification needed on numSignUps Count in MACI.sol
2 participants