feat(contracts): added message processor and tally addresses to the maci contract #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashgo0018
requested review from
ctrlc03,
kittybest,
0xmad and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /// @return poll The Poll contract object | ||
| function getPoll(uint256 _pollId) public view returns (address poll) { | ||
| /// @return pollContracts The Poll contract object | ||
| function getPoll(uint256 _pollId) public view returns (PollContracts memory pollContracts) { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the polls mapping to return the PollContracts struct instead of the poll address, it will now return the message processor address, tally contract address and poll contract address, when we will fetch the poll from the polls mapping and the getPoll function.
Confirmation