Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite using a GitHub API library #4

Open
probonopd opened this issue Mar 18, 2017 · 4 comments
Open

Rewrite using a GitHub API library #4

probonopd opened this issue Mar 18, 2017 · 4 comments

Comments

@probonopd
Copy link
Owner

probonopd commented Mar 18, 2017

E.g., https://github.com/turnkeylinux/octohub or another one from https://developer.github.com/libraries/

@d1vanov
Copy link

d1vanov commented Dec 17, 2017

I wrote a small tool in Go mimicking the uploadtool's behaviour - in fact, it was almost direct translation from upload.sh to golang, only with replacements of curl stuff with go-github library APIs calls. I did this rewrite because I need to handle binaries uploading not only from Travis CI but also from AppVeyor CI (Windows) for my project. I haven't yet started to use my tool in production but I have tested it extensively on the sample project.

Would you be interested in any kind of adoption of my tool as the replacement for upload.sh in future? If so, I'd be glad to help with it. Currently I have ignored the case of pull requests as transfer.sh is no longer functioning and the replacement hasn't been found yet (#28). My tool already allows to upload binaries from different branches of the build matrix to the same release (#3) (however, it has some implications for AppVeyor CI as described in the README).

Please don't consider this comment self-promotion or advertisement, I just scratched my own itch with this tool and figured it could potentially be useful to other people as well.

@probonopd
Copy link
Owner Author

probonopd commented Dec 17, 2017

Thank you very much @d1vanov - what is the reason you did not choose bash?
By the way, thank you for Quentier-x86_64.AppImage 👍

@d1vanov
Copy link

d1vanov commented Dec 17, 2017

Well, as @TheAssassin mentioned in #16, bash is just poorly suited for complex enough logics. Go is simple enough language but with strict static type system so the compiler checks many things for you during the compilation stage, long before some silly mistake has a chance to occur in runtime. And besides, there's a convenient GitHub API implementation in Go.

Thank you for all the efforts put into AppImage project, it rocks! 👍 And special thanks for finding the issue with my AppImage so quickly.

@lslvr
Copy link

lslvr commented Jan 3, 2018

Here's an implementation of the API written in shell script. As far as the script doesn't get too complex, shell scripts provide simpler solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants