Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we still use the smee proxy with serverless offline? #10

Closed
jakebolam opened this issue Jan 8, 2019 · 5 comments · Fixed by #59
Closed

Can we still use the smee proxy with serverless offline? #10

jakebolam opened this issue Jan 8, 2019 · 5 comments · Fixed by #59
Labels
released

Comments

@jakebolam
Copy link
Contributor

No description provided.

@jakebolam jakebolam mentioned this issue Jan 14, 2019
Closed
@jakebolam
Copy link
Contributor Author

jakebolam commented Jan 14, 2019 •
edited
Loading

Should we actually port all the config from probot-run ? https://github.com/probot/probot/blob/master/bin/probot-run.js#L24-L31

tldr: Some don't make sense for lambda here

@jakebolam
Copy link
Contributor Author

jakebolam commented Jan 14, 2019 •
edited by unfurl-links bot
Loading

Maybe need a serverless-plugin for this. Like the .env one which coincidentally would be good for this project too! https://github.com/colynb/serverless-dotenv-plugin

GitHub
Preload Environment Variables with Dotenv into Serverless - colynb/serverless-dotenv-plugin

@jakebolam
Copy link
Contributor Author

Happy to the make plugin!

@gr2m
Copy link
Contributor

gr2m commented Feb 9, 2021

With #59, you can continue to start your probot application function using probot run ./app.js which also supports the smee proxy. That should cover most use cases?

@gr2m gr2m mentioned this issue Feb 9, 2021
Merged
@gr2m gr2m closed this as completed in #59 Feb 10, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Probot v11 probot/adapter-aws-lambda-serverless
2 participants
@gr2m @jakebolam