Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore landing page #111

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Restore landing page #111

merged 5 commits into from
Jan 9, 2023

Conversation

ajschmidt8
Copy link
Contributor

@ajschmidt8 ajschmidt8 commented Dec 22, 2022

This PR restores the static landing page functionality (which is useful as a health check) that was lost during the v1 to v2 transition.

It also removes a dead link from the landing page.

Note: To avoid merge conflicts, I've based these changes on #91. That PR should be merged first.

The `error` field is not valid for an API Gateway response. As noted in the AWS docs below, when an error response contains invalid fields, it will always return a `502` error code with a body of `{"message": "Internal server error"}`. This PR updates the error response fields to contain valid fields and a more sensible response message.

- https://docs.aws.amazon.com/lambda/latest/dg/services-apigateway.html#services-apigateway-errors
@gr2m gr2m merged commit 21610ac into probot:master Jan 9, 2023
@ajschmidt8 ajschmidt8 deleted the restore-landing-page branch January 9, 2023 23:36
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants