Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Probot v10 #43

Closed
gr2m opened this issue Sep 1, 2020 · 2 comments · Fixed by #46
Closed

Upgrade to Probot v10 #43

gr2m opened this issue Sep 1, 2020 · 2 comments · Fixed by #46

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 1, 2020

Hello Lambda friends,

we just released Probot v10 and I'd like to upgrade @probot/serverless-lambda for compatibility. Would any existing user/contributor would like to collaborate on that with me?

More importantly, I'd like to make this package obsolete with Probot v11. I'm not sure how it would look like, but making Probot play nicely with serverless environments is our priority for the next release. Please join the discussion at
probot/probot#1286

@soberstadt
Copy link

I would love to see this happen too! I know two things that need to get updated are the imports in index.js:
https://github.com/probot/serverless-lambda/blob/52dafe0b84b117b97570b7c8add96552ff6e331b/index.js#L2-L3
to

const { resolve } = require('probot/lib/helpers/resolve-app-function')
const { findPrivateKey } = require('probot/lib/helpers/get-private-key')

@scolandrea
Copy link
Contributor

Thanks, @soberstadt I just created a PR based on your recommendations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants