Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #61 : Smoke test / Probot v11 migration key points / Common errors #63

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix #61 : Smoke test / Probot v11 migration key points / Common errors #63

merged 1 commit into from
Feb 23, 2021

Conversation

axel3rd
Copy link
Contributor

@axel3rd axel3rd commented Feb 23, 2021

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few nits

.gitignore Outdated Show resolved Hide resolved
README.md Outdated
Comment on lines 75 to 78
| Http Code | Message | Description
| --- | --- | --- |
| 403 | Missing Authentication Token | Bad endpoint (this one is not binded on Lambda) |
| 500 | Internal server error | Incorrect headers value (`X-GitHub-Delivery`, `X-GitHub-Event`, `X-Hub-Signature`) or Probot error |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run npm run lint:fix? That will format the markdown tables

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@axel3rd axel3rd requested a review from gr2m February 23, 2021 17:57
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gr2m gr2m merged commit 0d7f338 into probot:master Feb 23, 2021
@axel3rd axel3rd deleted the doc-improvments branch February 23, 2021 18:14
@github-actions
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants