Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when there is no "account" property #30

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Oct 12, 2020

Extract either account the GitHub App is installed to, organization or account as a username.

Fixes #28

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thank you! I'll investigate the missing account property to better understand the circumstances when it's present and when it's not.

@mikz
Copy link
Contributor Author

mikz commented Oct 12, 2020

@gr2m force pushed a version with tests.

I went for the native API, because it is way easier to stub Sentry rather than going for a fake server.

Extract either account the GitHub App is installed to, organization or account as a username.
@gr2m
Copy link
Contributor

gr2m commented Oct 12, 2020

I went for the native API, because it is way easier to stub Sentry rather than going for a fake server.

Just saw it, today I learned. This is a great pull request Michal, thank you!

@gr2m gr2m merged commit 71d4be4 into probot:main Oct 12, 2020
@mikz mikz deleted the patch-1 branch October 12, 2020 16:39
@github-actions
Copy link

🎉 This PR is included in version 1.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when the installation is missing "account"
2 participants