Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade @sentry/node to v7 #319

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dsanders11
Copy link
Contributor

This PR upgrades just @sentry/node to v7 to help clear downstream audit failures related to GHSA-pxg6-pf52-xh8x. I'm only jumping to @sentry/node v7 as it's still maintained, and supports down to Node.js v8 so this doesn't need to be a breaking change for @probot/pino.

cc @gr2m

@gr2m
Copy link
Contributor

gr2m commented Oct 15, 2024

hmmm unfortunately the CI is failing anyway, with a cryptic error. I don't have time to look into it myself I'm afraid, but happy to merge when we get the tests to green

@dsanders11
Copy link
Contributor Author

Thanks @gr2m. Tests passed locally, so I'll dig into the cryptic CI failures.

@dsanders11
Copy link
Contributor Author

@gr2m, this should be ready to run CI again. I think the cryptic issue was an npm bug (I'm using 10.8.2) - it updated the lockfile to add fsevents as a dep for chokidar (it's an optional dependency in that version) but it didn't add fsevents itself to the lockfile. I manually removed the added fsevents line it added since it shouldn't be touching existing dependencies anyway. Ran npm ci locally which repro'd the issue and now runs successfully after that change.

@gr2m
Copy link
Contributor

gr2m commented Oct 15, 2024

Outstanding work @dsanders11. Thank you so much for digging into it, and for figuring it out, and for fixing it! Much appreciated!

@gr2m gr2m merged commit 92c4681 into probot:main Oct 15, 2024
5 checks passed
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dsanders11 dsanders11 deleted the feat/update-sentry-node-v7 branch October 15, 2024 20:30
@dsanders11 dsanders11 mentioned this pull request Oct 16, 2024
Copy link

🎉 This PR is included in version 3.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants