Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getTransformStream): compare opts.logLevelInString as boolean #116

Merged
merged 2 commits into from
May 28, 2021
Merged

fix(getTransformStream): compare opts.logLevelInString as boolean #116

merged 2 commits into from
May 28, 2021

Conversation

JacopoDaeli
Copy link
Contributor

@JacopoDaeli JacopoDaeli commented May 27, 2021 •
edited by gr2m
Loading

options.logLevelInString is a boolean, so comparing with a string will always result in levelAsString to be false.

closes probot/probot#1541

@gr2m
Copy link
Contributor

gr2m commented May 27, 2021

Thanks! Must have been a left over from when we compared to values of environment variables!

Could you please add a test, ideally one that would break before your change, so we don't accidentally introduce a regression in future?

@JacopoDaeli JacopoDaeli mentioned this pull request May 28, 2021
Closed
@JacopoDaeli
Copy link
Contributor Author

@gr2m I tweak the test a bit to cover this scenario. Everything should be good. If not, feel free to change things as you prefer.

@gr2m gr2m self-assigned this May 28, 2021
gr2m
gr2m approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR Jacopo 💐

@gr2m gr2m merged commit 1bca0bb into probot:main May 28, 2021
@github-actions
Copy link

🎉 This PR is included in version 2.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees

@gr2m gr2m

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom logger's message key
2 participants
@JacopoDaeli @gr2m