Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete merged branches #869

Closed
montoyamoraga opened this issue Sep 7, 2020 · 4 comments
Closed

delete merged branches #869

montoyamoraga opened this issue Sep 7, 2020 · 4 comments

Comments

@montoyamoraga
Copy link
Member

i think two branches can be safely deleted, since they were merged:
https://github.com/processing/p5.js-website/branches

"feature/footerUpdate"
https://github.com/processing/p5.js-website/tree/feature/footerUpdate

"integrating_showcase.p5js.org"
https://github.com/processing/p5.js-website/tree/integrating_showcase.p5js.org

i'm less sure, but maybe the branch "teach" can also be deleted
https://github.com/processing/p5.js-website/tree/teach
even though it doesn't show as merged here
https://github.com/processing/p5.js-website/branches
according to this PR it can be safely deleted?
https://github.com/processing/p5.js-website/pull/851#event-3733423101
but maybe @connieliu0 still needs this branch?

@connieliu0
Copy link
Contributor

hi!, integrating_showcase.p5js.org can definitely be deleted, I'll do it now :) not sure about teach- maybe @yinhwa can comment on this?

@yinhwa
Copy link
Contributor

yinhwa commented Sep 14, 2020

Hi @montoyamoraga could we have the teach branch left for now :)? I think I can work on adding some teaching cases throughout next couple months. If you believe pulling request directly to the main branch more efficient, we can delete it too!

@montoyamoraga
Copy link
Member Author

okie @yinhwa , lets leave the teach branch open for you, i am just a fan of not leaving stale branches open :) so we will be good

@yinhwa
Copy link
Contributor

yinhwa commented Sep 15, 2020

@montoyamoraga much thanks as always aarónieee :)))) i'll let you know when I can close the branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants