-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Workflow Spends Over 20 Minutes on File Compression #647
Comments
#615 will fix this to a certain extend, I still need to fix some bugs though. However, Only CI should run |
Hi @SableRaf and the p5.js-website team, I noticed your discussion regarding extended build times, particularly during the AstroCompress processing phase. I recently developed a tool called mysong-compress to address similar challenges with my Astro website. This tool offers comparable compression capabilities and includes a caching mechanism designed to significantly reduce build times for larger projects. In my case the build time went from over 10 minutes down to 1 minute. I invite you to try out mysong-compress in your build process. If you do, I would greatly appreciate it if you could share your build time measurements and output folder sizes for the following scenarios:
Please post your findings in this issue. Your feedback would be invaluable in assessing the effectiveness of mysong-compress and identifying areas for further improvement. Thank you for considering this, and I look forward to any insights you might provide. In case you're interested, I can also offer to create a PR integrating mysong-compress for you to have a look. Best regards, |
@wlami Thanks for the ping. We have a mostly complete solution in #615 that also recreates the compression that astro-compress does. It is achieving the same and a bit better compression than astro-compress and our build time is halved from 20 minutes to 10 minutes. I haven't tried out your implementation yet but I had a look at the repo and I have a couple suggestion based on what I found while working on our solution.
|
Addressed by #694. For further build speed improvements it likely need to come from Astro, I can optimize the compression a little bit more but it likely won't provide further speed improvements. I imagine once Vite managed to switch to Rolldown, Astro which uses Vite underneath should see good improvements to build and dev speed. I'll close this for now. |
The p5.js website build workflow takes over 20 minutes, with significant time spent on the compression step (labelled
AstroCompress processing
in the logs) for html, images, and other files. This duration impacts the developer experience and considerably slows down iterations during development.See for example: GitHub Action Log
Relevant issues in the repository for Astro's compression library:
Suggestions
The text was updated successfully, but these errors were encountered: