Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curvy facades #17

Closed
vvoovv opened this issue May 25, 2021 · 12 comments
Closed

Curvy facades #17

vvoovv opened this issue May 25, 2021 · 12 comments

Comments

@vvoovv
Copy link
Member

vvoovv commented May 25, 2021

Classification of curvy facades produces odd results:

(bern_old_town.osm, Kirche St. Peter und Paul):
image

@vvoovv
Copy link
Member Author

vvoovv commented May 25, 2021

(bern_old_town.osm, Kirche St. Peter und Paul):

image

@vvoovv
Copy link
Member Author

vvoovv commented May 25, 2021

I suggest skipping curvy facades from from the visibility and classification calculations.

@vvoovv
Copy link
Member Author

vvoovv commented May 25, 2021

How to define a curvy facade?

A curvy facade is a sequence of narrow facades connecting each other "smoothly".

@polarkernel
Copy link
Collaborator

A curvy facade is a sequence of narrow facades connecting each other "smoothly".

Are we back to apse detection (see prochitecture/bpypolyskel#5 (comment))?

@vvoovv
Copy link
Member Author

vvoovv commented May 25, 2021

A curvy facade is a sequence of narrow facades connecting each other "smoothly".

Are we back to apse detection (see prochitecture/bpypolyskel#5 (comment))?

A curvy facade can have an arbitrary shape.

@vvoovv
Copy link
Member Author

vvoovv commented May 26, 2021

I suggest skipping curvy facades from from the visibility and classification calculations.

That was the wrong idea.

A front part must be still detected to place an entrance. For example, suppose we have a building with a circular footprint (it could be an ancient tower). It still needs an entrance.

@vvoovv
Copy link
Member Author

vvoovv commented May 26, 2021

Curvy sequences can be also concave. Example.

@vvoovv
Copy link
Member Author

vvoovv commented May 26, 2021

A curvy sequence must be classified if

  1. there is no entrance tagged in OSM for all edges
    AND
  2. there are no wide edges classified as the front facades

One approach would be to connect the first and the last node of the curve sequence with a straight line and use that proxy edge for the visibility calculation and classification. But how would it work for a concave sequence if a way follows the concave sequence and is located very close to the concave sequence?

@vvoovv
Copy link
Member Author

vvoovv commented May 26, 2021

A special case is a completely curvy building. Example: a circular footprint.

@vvoovv
Copy link
Member Author

vvoovv commented May 27, 2021

Are we back to apse detection (see prochitecture/bpypolyskel#5 (comment))?

The apse detection and the detection of other patterns will required to generate realistic models of churches and cathedrals.

@vvoovv
Copy link
Member Author

vvoovv commented May 27, 2021

Many stadiums have curvy footprint.

@vvoovv
Copy link
Member Author

vvoovv commented May 27, 2021

Joined with #16.

@vvoovv vvoovv closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants