-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curvy facades #17
Comments
I suggest skipping curvy facades from from the visibility and classification calculations. |
How to define a curvy facade? A curvy facade is a sequence of narrow facades connecting each other "smoothly". |
Are we back to apse detection (see prochitecture/bpypolyskel#5 (comment))? |
A curvy facade can have an arbitrary shape. |
That was the wrong idea. A front part must be still detected to place an entrance. For example, suppose we have a building with a circular footprint (it could be an ancient tower). It still needs an entrance. |
Curvy sequences can be also concave. Example. |
A curvy sequence must be classified if
One approach would be to connect the first and the last node of the curve sequence with a straight line and use that proxy edge for the visibility calculation and classification. But how would it work for a concave sequence if a way follows the concave sequence and is located very close to the concave sequence? |
A special case is a completely curvy building. Example: a circular footprint. |
The apse detection and the detection of other patterns will required to generate realistic models of churches and cathedrals. |
Many stadiums have curvy footprint. |
Joined with #16. |
Classification of curvy facades produces odd results:
(bern_old_town.osm, Kirche St. Peter und Paul):
![image](https://user-images.githubusercontent.com/613295/119490793-eb2eee00-bd65-11eb-899c-297a5c03765d.png)
The text was updated successfully, but these errors were encountered: