Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path magic feature and bug #10

Open
benj919 opened this issue Apr 20, 2020 · 1 comment
Open

path magic feature and bug #10

benj919 opened this issue Apr 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@benj919
Copy link
Collaborator

benj919 commented Apr 20, 2020

Currently there is quite some magic going on trying to divine the config, input, and output paths from partial info when running a simulation. Currently it is a bit inconsistent and intransparent on what is going on. Should we remove all/most of it and instead expect all three to be provided when calling a simulation?

The only part I'd keep is creating a subfolder with the config name in the output path.

(config_handling.R, prepare_directories, lines 16-81)

@benj919 benj919 added bug Something isn't working enhancement New feature or request labels Apr 20, 2020
@ohagen
Copy link
Member

ohagen commented Apr 20, 2020

I agree. We should think first on how to organize the outputs... now, if using config object I take the path from the input, while if using aconfig file it takes the path from the input. I added some additional printis to help the user a bit, but only informs after launched. Maybe just let's keep landscape (specious input) as the folder structure. I will git it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants