Treat initial and subsequent resync events identically for node ip #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.Panicf("Invalid node event. Type: %s, Object: %+v", e.Type, e.Object) | ||
| } | ||
|
|
||
| func splitNodeEvent(node *k8sapi.Node) (*model.KVPair, *model.KVPair) { |
There was a problem hiding this comment.
minor naming nit: I'd just call this splitNode since it's not actually taking an Event struct as an input, rather a Node.
caseydavenport
approved these changes
Aug 4, 2017
|
OK LGTM - test's in a separate PR as discussed. |
3 tasks
song-jiang
pushed a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 19, 2021
…lico#486) * [SAAS-1407] Update PacketCapture with a status subresource * [CODE REVIEW] Use named values instead of string as key * [CODE REVIEW] Add directory and more comments Co-authored-by: Alina Militaru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor parsing the KDD node syncer event so that common code between a new sync and an update sync event are treated the same. Prior to this fix the new sync event path sent incorrectly formatted node event to clients (e.g. felix).
See https://github.com/projectcalico/libcalico-go/issues/485 for details.
Note: a unit test is in the works.
Todos
Release Note