k8s conversion code handles 1.7 clusters #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
caseydavenport
commented
Sep 24, 2017
| @@ -846,6 +846,421 @@ var _ = Describe("Test NetworkPolicy conversion", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| // This suite of tests is useful for ensuring we continue to support kubernetes apiserver | |||
| // versions <= 1.7.x, and can be removed when that is no longer required. | |||
| var _ = Describe("Test NetworkPolicy conversion (k8s <= 1.7, no policyTypes)", func() { | |||
There was a problem hiding this comment.
This is a copy of the NetworkPolicy tests from above (minus egress/cidr), but each with the policyTypes section removed to make it look like it would appear on a k8s 1.7 cluster.
The assertions made in each test are the same.
bcreane
approved these changes
Sep 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes our conversion logic in KDD such that it works on clusters running k8s <=v1.7.0.
In this scenario, the API doesn't return a
policyTypesfor any NetworkPolicies and we need to thus infer that the policy should only affect ingress traffic since k8s pre-1.8 (and pre-policyTypes) didn't support egress policies.Todos
Release Note