gopkg.toml: upgrade to client-go v9.0.0 / kubernetes v1.12.6 #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amarnath <[email protected]>
vaamarnath
commented
Mar 12, 2019
| @@ -56,10 +56,16 @@ | |||
| "envoy/api/v2/listener", | |||
| "envoy/api/v2/route", | |||
| "envoy/config/accesslog/v2", | |||
| "envoy/config/bootstrap/v2", | |||
There was a problem hiding this comment.
These dependencies got added when I ran dep ensure after updating Gopkg.toml. I double-checked if it is genuine by running dep check and looks like these were missing from Gopkg.lock earlier.
➜ contour git:(client-go-update-1.12) ✗ dep check
# Gopkg.lock is out of sync:
github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v2: imported or required, but missing from Gopkg.lock's input-imports
github.com/envoyproxy/go-control-plane/envoy/config/metrics/v2: imported or required, but missing from Gopkg.lock's input-imports
There was a problem hiding this comment.
Who can say, dep is pretty buggy
|
@vaamarnath i'll merge this today. If you want to raise a p2 issue for |
|
@davecheney Yeah, I see there is an issue (#598) open already for moving to go modules. I will not raise an issue for |
|
I’m not sure what dep check is upset about, but it’s probably been upset for a long time and nothing bad has happened. I don’t see any warnings during the Travis ci builds so I think we can live with this debt til 0.12
… On 13 Mar 2019, at 14:02, Amarnath ***@***.***> wrote:
@davecheney Yeah, I see there is an issue (#598) open already for moving to go modules. I will not raise an issue for dep check complaining for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amarnath [email protected]
Fixes #934