Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend exclude pattern functionality #1427

Closed
Mzack9999 opened this issue Nov 3, 2023 · 0 comments · Fixed by #1517
Closed

Extend exclude pattern functionality #1427

Mzack9999 opened this issue Nov 3, 2023 · 0 comments · Fixed by #1517
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@Mzack9999
Copy link
Member

Please describe your feature request:

exclude-cdn and exclude-private-ips should be deprecated, then merged and extended into a unique exclude flag that accepts:

  • CIDRs (x.x.x.x/y)
  • Hosts (*.scanme.*.sh)
  • Regexes (^test$)
  • CDNs (cdn)
  • Private IPs (private-ips)
  • Ports (*:8080)

Example:

httpx -exclude cdn,private-ips,http://*scanme.sh,*:8080,1.0.0.0/24

Each tools has its own implementation, hence it would be interesting implementing it as a shared logic that could be plugged into all of them. For example we can add a callback to fastdialer.OnBeforeConnect where we check all supported patterns.

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Nov 3, 2023
@dogancanbakir dogancanbakir self-assigned this Dec 25, 2023
@Mzack9999 Mzack9999 linked a pull request Jan 7, 2024 that will close this issue
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jan 7, 2024
@ehsandeep ehsandeep added this to the httpx v1.3.8 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants