-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headless issue with root user #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
added
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Nov 9, 2022
Mzack9999
requested changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - minor changes suggested
Mzack9999
approved these changes
Nov 11, 2022
ehsandeep
approved these changes
Nov 11, 2022
ehsandeep
removed
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #131.
This PR adds two flags as suggested:
I don't know actually if this is the best solution possible,
-hns
seems redundant when-hoa
is present. Another solution could be try to detect if the user has sudo privileges (only on Linux?).However, now it seems to work well with both two new flags:
Using -hoa
Using -hns
Moreover, I have added some tests in order to check errors in the new function
ParseHeadlessOptionalArguments()
and the functionParseCustomHeaders()
.This PR closes #131.