Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto increase depth when -kf is used #655

Merged
merged 3 commits into from
Nov 30, 2023
Merged

auto increase depth when -kf is used #655

merged 3 commits into from
Nov 30, 2023

Conversation

dogancanbakir
Copy link
Member

$ go run . -u https://remoteadvisor-east1.apple.com/ -hl --system-chrome -xhr-extraction -kf all -depth 2 -aff -s
 breadth-first -iqp -H "User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/118.0.0.0 Safari/537.36" -o 
a.json
[INF] Depth automatically set to 3 to accommodate the `--known-files` option (originally set to 2).

   __        __                
  / /_____ _/ /____ ____  ___ _
 /  '_/ _  / __/ _  / _ \/ _  /
/_/\_\\_,_/\__/\_,_/_//_/\_,_/                                                   

                projectdiscovery.io

[INF] Current katana version v1.0.4 (latest)
[INF] Started headless crawling for => https://remoteadvisor-east1.apple.com/
https://remoteadvisor-east1.apple.com/api/
https://remoteadvisor-east1.apple.com/files/
https://remoteadvisor-east1.apple.com/appliance/
https://remoteadvisor-east1.apple.com/us/search?src=globalnav
https://remoteadvisor-east1.apple.com/content/access_key_input.js
https://www.apple.com/ac/globalfooter/2.0/en_US/scripts/ac-globalfooter.built.js
https://remoteadvisor-east1.apple.com/
https://remoteadvisor-east1.apple.com/api/content/core.js
https://remoteadvisor-east1.apple.com/api/start_session.js
https://remoteadvisor-east1.apple.com/content/portal.js
https://remoteadvisor-east1.apple.com/content/lib/jquery.js
https://remoteadvisor-east1.apple.com/content/common.css
https://remoteadvisor-east1.apple.com/content/public.css
^C[INF] - Ctrl+C pressed in Terminal
http://www.apple.com/ipad/
https://remoteadvisor-east1.apple.com/content/mobile.css
http://www.apple.com/iphone/
http://www.apple.com/support/
http://www.apple.com/music/
https://remoteadvisor-east1.apple.com/content/portal-customizations.css?_c=0
https://remoteadvisor-east1.apple.com/check_access_key?access_key_submit=Submit&access_key_pretty=katana
http://www.apple.com/us/shop/goto/bag
https://remoteadvisor-east1.apple.com/login/
http://www.apple.com
[INF] Creating resume file: /home/vscode/.config/katana/resume-cl57jts3j6edcmukr30g.cfg

Closes #641.

@dogancanbakir dogancanbakir self-assigned this Nov 7, 2023
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation: LGTM

Maybe we can move this in an helper method like Options.Validate(...) in pkg/types/options.go so it's also accessible when katana is used via SDK. What do you think?

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 8, 2023
@Mzack9999 Mzack9999 linked an issue Nov 8, 2023 that may be closed by this pull request
@ehsandeep ehsandeep merged commit 80dd3d0 into dev Nov 30, 2023
13 checks passed
@ehsandeep ehsandeep deleted the depth_auto_increase branch November 30, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-known-files does not work with -depth 1 or -depth 2
3 participants