Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issues relates do character encoding #308

Closed
wants to merge 2 commits into from

Conversation

axmachado
Copy link

Solve issues #286, #239 and #153.

The approach here is to use unicode string all the way, and encode it to the system default encoding only when writing to console or file. It changes a bit how things are done in "stuff.py" and "reports.py", formatting all strings in unicode before encoding to the system charset.

I removed some hardcoded "utf-8" encodings, converting it to Unicode strings.

For me, it solved all the encoding issues that where making hamster unusable in my system. I hope it work for you all too.

There is some risk of this patch breaking something related to bug 562298 (encoding issue with Japanese locale). I think it will not break, but I was unable to test it. If someone that uses Japanese locale can test, I will be glad.

I can spare some more hours to work with hamster, so, if anyone thinks any bug is really annoying, please, let me know.

@dClauzel
Copy link

When generating a web report, the names with accents are broken.

Example, for the month of december "déc." becomes "déc.".

@ederag
Copy link
Collaborator

ederag commented Nov 30, 2018

Thanks a lot.
This utf-8 issue has hopefully been fixed by the python3 migration.

@ederag ederag closed this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants