Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Synchronized uses this.FOO to access static locks instead of Self.FOO. #678

Closed
lombokissues opened this issue Jul 14, 2015 · 3 comments
Closed
Milestone

Comments

@lombokissues
Copy link

Migrated from Google Code (issue 643)

@lombokissues
Copy link
Author

👤 reinierz   🕗 Feb 20, 2014 at 15:47 UTC

When using explicitly named locks (@ Synchronized("MYTHING")) on an instance method, if the lock field referenced is static, lombok still generates synchronized (this.MYTHING). While we can't do resolution, IF we can find the field (99.9% of all use cases, that'll be the case. The whole point of @ Synchronized is to internalize all locks, after all) , we can check if it is static.

@lombokissues
Copy link
Author

End of migration

@rzwitserloot rzwitserloot added this to the 1.20.0 milestone Feb 10, 2020
@rzwitserloot
Copy link
Collaborator

This is a simple fix, let's knock a 5 year old bug out for 1.20 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants