Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close button to suggested reading popups #96

Open
jdpigeon opened this issue Aug 8, 2017 · 1 comment
Open

Add close button to suggested reading popups #96

jdpigeon opened this issue Aug 8, 2017 · 1 comment

Comments

@jdpigeon
Copy link

jdpigeon commented Aug 8, 2017

I notice these suggested reading popups in many places across the site

suggestionexample

They're nice, but the inner neat-freak in me wants to be able to close them.

I see them defined in the _layouts .html files. It shouldn't be too hard to add a close button

I'll look into this and make a PR

@ahmetcecen
Copy link
Member

The sidebar content was hastily designed and can certainly use many improvements. Feel free to improve on it.

Note that the sidebar content will only be visible in screens with a resolution close to 1080p at the moment. This is probably another area of improvement, like stacking them below the page etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants