Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential file not downloading after v3.0 upgrade #58

Closed
rajeevkrishnanv opened this issue Dec 16, 2022 · 7 comments · Fixed by salsify/samltoawsstskeys#2
Closed

Credential file not downloading after v3.0 upgrade #58

rajeevkrishnanv opened this issue Dec 16, 2022 · 7 comments · Fixed by salsify/samltoawsstskeys#2

Comments

@rajeevkrishnanv
Copy link

The credentials file is not getting downloaded after latest update. Since the logs contain sensitive information, I'm posting masked screenshots. Hope that will help

logs
error
logs-rolelist

@Wildhammer
Copy link

Similar issue since this morning.

@pjbhaumik
Copy link

I am seeing the issue with chrome. It is working with Firefox still... This means that there is an issue with the chrome compatibility.

@prolane
Copy link
Owner

prolane commented Dec 16, 2022

Thanks @rajeevkrishnanv for posting the issue. Due to new Google policies I had to refactor the code quite a bit. Unfortunately such changes always introduce the risk of code breaking down in certain situations.

The issue is related to a new xml parser I'm using. Before I was using DOM selectors on the xml, but under new Google policies this is not possible anymore. Apparently there are some variations in how the SAML xml is structured. This results in a slightly different data object after parsing.

More specific;
In my code I'm expecting attributes_role_list to be a list of strings. Now it appears in some cases this list can be a list of objects, with each object having a key #text which holds the actual value (the string I'm expecting).

I have sufficient information to debug this issue. I'm out for the evening, but I'll fix this tomorrow morning.

@prolane
Copy link
Owner

prolane commented Dec 16, 2022

I am seeing the issue with chrome. It is working with Firefox still... This means that there is an issue with the chrome compatibility.

@pjbhaumik The FireFox extension is created from this code base, but I'm not maintaining it myself. The FireFox extension is still on a previous version. This is why this one still works.

I'll be working on a fix soon though.

@prolane
Copy link
Owner

prolane commented Dec 16, 2022

I've submitted v3.1. When Google finishes the review, it will be automatically published to the web store.

The fix is primarily a changed configuration of the xmlparser. This should allow for a unified way of processing the the SAML Assertion Attributes, instead of having to code exceptions.

@rajeevkrishnanv, let me know once v3.1 is available if this fixed the issue for you.

@joshbranham
Copy link

3.1 just updated for me and the file is downloading 👍

@rajeevkrishnanv
Copy link
Author

Thanks a lot @prolane . It worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants