Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getItemPosition (and possibly indexOf, etc) returning wrong index for WeekMode #292

Closed
ekchang opened this issue May 11, 2016 · 3 comments
Closed
Labels

Comments

@ekchang
Copy link
Contributor

ekchang commented May 11, 2016

#285 #291

Reproducible by creating a RV of MCVs, setting them to Week mode, and scrolling them off screen to trigger CalendarPagerAdapter#getItemPosition and calling setMinimumDate(today) during onBind. As of 05/10/2016, on creation the calendar shows week of 05/04 - 05/10, but scroll through and it will rebind as 04/27 - 05/03. This is because month mode would have shown minDate as 04/27 (which is correct) but week mode has no intelligent way of setting a narrower minDate at the moment.

@quentin41500
Copy link
Member

Seems like the issue is coming from materialCalendarView#setFirstDayOfWeek(Calendar.WEDNESDAY);

@quentin41500
Copy link
Member

Related to #222

@quentin41500
Copy link
Member

This issue has been fixed and is available in the 1.3 snapshot. Stay tuned for the next release.You can try the 1.3 snapshot with the instructions in README. Enjoy and report issues!

@ekchang ekchang closed this as completed May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants