Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setMaximumDate(date) in 'weeksMode' does not disable weeks paging like the way in 'monthsMode' #293

Closed
joecizac opened this issue May 11, 2016 · 7 comments
Labels

Comments

@joecizac
Copy link

No description provided.

@ekchang ekchang added the bug label May 11, 2016
@ekchang
Copy link
Contributor

ekchang commented May 11, 2016

I need to look into this. I believe minDate and maxDate for weeks is not WIA.

@emitchel
Copy link

@joecizac, @ekchang this is an easy fix I've done locally:

In MaterialCalendarView#setCalendarDisplayMode(...)

it doesn't call adapter.setRangeDates(minDate,maxDate) even though it sets the max and min in adapter.migrateStateAndReturn(...). Calling adapter.setRangeDates(...) will init the bounds of the new adapter.

My apologies for not submitting a PR, have been working to get it implemented and this, along with a number of other small items, have forced me to pull locally for now.

@joecizac
Copy link
Author

joecizac commented May 12, 2016

@emitchel it didn't work. It's locking the paging a week or two before the actual max date.
I think this is related to #222 because i'm facing that issue as well.

@ekchang
Copy link
Contributor

ekchang commented May 13, 2016

We will be releasing a 1.3 snapshot soon. You're encouraged to try it out and let us know if these problems are still existent. Please tag any issues with the 1.3 snapshot with the 1.3-SNAPSHOT label. Thanks!

Going forward, we will probably tag Week mode as @Experimental until we are certain of its stability.

@joecizac
Copy link
Author

@ekchang Looking forward to test the snapshot.

@ekchang
Copy link
Contributor

ekchang commented May 13, 2016

Snapshot instructions: Change to the snapshot maven URL and add compile 'com.prolificinteractive:material-calendarview:1.3.0-SNAPSHOT' to your dependencies. Please report any issues you find with the label 1.3-SNAPSHOT. Thanks!

@ekchang
Copy link
Contributor

ekchang commented May 16, 2016

Confirm whether the issue is still present now that 1.3.0 is live.

@ekchang ekchang closed this as completed May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants