Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to modify the parameters #675

Closed
fcddk opened this issue Nov 8, 2019 · 1 comment
Closed

Suggest to modify the parameters #675

fcddk opened this issue Nov 8, 2019 · 1 comment

Comments

@fcddk
Copy link

fcddk commented Nov 8, 2019

func NewConstMetric(desc *Desc, valueType ValueType, value float64, labelValues ...string)
func MustNewConstMetric(desc *Desc, valueType ValueType, value float64, labelValues ...string)

Suggest: change labelValues ...string to []string,

Personally think that it is easier to use.

@beorn7
Copy link
Member

beorn7 commented Nov 8, 2019

I guess there will always be people leaning towards one side or the other.

In any case, changing it would be a breaking change for one of the most frequently used Go packages. That's a big price for such a small (and disputed) effect.

(Also note that these functions will look very different in v2 of the library, see #222 .)

@beorn7 beorn7 closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants