Unwanted rollbacks on exception raises

[andre-cavalheiro]

Hey there, I created my own placeholder that fits my needs perfectly, except for one use-case, which I can't figure out why it's happening. Here's a slight simplification of the code so it'll be easier to read.

def instrumentation_log():
  def decorator(func):
    def wrapper(*args, **kwargs):
      try:
        response = func(*args, **kwargs)
      except Exception as e:
        counter_errors_metric.inc()
        raise e
      counter_requests_metric.inc()
      return response
    return wrapper
  return decorator

This should be a simple plug-and-play decorator that simply increases one of two counters, depending on whether the target function completes successfully or throws an exception.

Once the error counter is incremented, I want to raise the exception all the same, so the workflow can continue as it usually would without the decorator. However, once I raise the exception, the count increment seems to be "rolled back" for some reason, since my call to registry.get_sample_value returns None. I'm sure this is because of that raise e, because without it, this works out fine.

Is this rollback behavior expected? Is there a simple way to overcome it?

[andre-cavalheiro]

I was able to fix this, it turns out that the issue had nothing to do with the client itself, but due to our testing framework instead.

I'm not able to delete the post, but it can be archived.