Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Descriptor::new const #139

Closed
mxinden opened this issue May 9, 2023 · 1 comment
Closed

Make Descriptor::new const #139

mxinden opened this issue May 9, 2023 · 1 comment

Comments

@mxinden
Copy link
Member

mxinden commented May 9, 2023

Consider making Descriptor::new const. This would be handy when used with Collector when passing a borrowed 'static `Descriptor.

As far as I can tell, the only current blocker is the string manipulation to add a ,:

client_rust/src/registry.rs

Lines 437 to 438 in 85033bf

let help = help.into() + ".";

@mxinden
Copy link
Member Author

mxinden commented Sep 7, 2023

With #149 this is obsolete.

@mxinden mxinden closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant