Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iterating the metrics on an registry #163

Closed
flaneur2020 opened this issue Sep 15, 2023 · 1 comment
Closed

Allow iterating the metrics on an registry #163

flaneur2020 opened this issue Sep 15, 2023 · 1 comment

Comments

@flaneur2020
Copy link
Contributor

I'm working on a database that has a built-in system table for providing metric values to users.

At present, I have to dump these metrics into a string and then parse it to retrieve the samples.

I discovered that MetricsIterator perfectly aligns with my requirements for this feature. But unfortunately, it's marked as pub(crate), which prevents me from calling this iterator externally.

I'm wondering if this limitation was intentionally by-design or not?

Thank you a lot.

@mxinden
Copy link
Member

mxinden commented Oct 16, 2023

👋

Yes, making it pub(crate) was a deliberate decision. The smaller the surface of this library, the easier it is to maintain and evolve it. Since #149 it is replaced by an alternative internal implementation and thus no longer available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants