Add wasm32 as a cross-compile target
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Aug 10, 2022
| @@ -147,6 +147,7 @@ jobs: | |||
| - mipsel-unknown-linux-gnu | |||
| - powerpc-unknown-linux-gnu | |||
| - powerpc64-unknown-linux-gnu | |||
| - wasm32-unknown-unknown | |||
There was a problem hiding this comment.
Suggested change
| - wasm32-unknown-unknown | |
| - wasm32-unknown-unknown | |
| - wasm32-unknown-emscripten, | |
| - wasm32-wasi |
Would it make sense to test against these targets as well?
There was a problem hiding this comment.
I think wasm32-unknown-unknown is the most restrictive one. If it works for those, it should work for the others too :)
There was a problem hiding this comment.
Understood. Let's proceed as is then.
mxinden
approved these changes
Aug 10, 2022
| @@ -147,6 +147,7 @@ jobs: | |||
| - mipsel-unknown-linux-gnu | |||
| - powerpc-unknown-linux-gnu | |||
| - powerpc64-unknown-linux-gnu | |||
| - wasm32-unknown-unknown | |||
There was a problem hiding this comment.
Understood. Let's proceed as is then.
ackintosh
pushed a commit
to ackintosh/client_rust
that referenced
this pull request
Aug 27, 2022
…s#79) Signed-off-by: ackintosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.