Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting of home path to createAppAndExport app setup #458

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

channa-figure
Copy link
Contributor

Description

Add home directory to for createAppAndExport to use. It was using a hard coded "", but now will check to see if home path was set from cli.

closes: #457


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@channa-figure channa-figure added bug Something isn't working wasm labels Aug 30, 2021
@channa-figure channa-figure added this to the v1.7.0 milestone Aug 30, 2021
@channa-figure channa-figure self-assigned this Aug 30, 2021
@channa-figure channa-figure marked this pull request as ready for review August 30, 2021 21:13
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #458 (ec33c64) into main (1f52a53) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   54.87%   54.85%   -0.02%     
==========================================
  Files         143      143              
  Lines       17817    17822       +5     
==========================================
  Hits         9777     9777              
- Misses       7307     7312       +5     
  Partials      733      733              
Impacted Files Coverage Δ
cmd/provenanced/cmd/root.go 62.00% <0.00%> (-1.39%) ⬇️

Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dwedul-figure dwedul-figure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@channa-figure channa-figure enabled auto-merge (squash) August 30, 2021 22:03
@channa-figure channa-figure merged commit 4ff2d0d into main Aug 30, 2021
@channa-figure channa-figure deleted the 457-fix-wasm-home-dir-on-export branch August 30, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createAppAndExport does not send the correct wasm home directory to wasm keeper
3 participants