Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Action that runs gallery against a list of notable projects #1390

Closed
ambv opened this issue May 8, 2020 · 2 comments · Fixed by #2725
Closed

Add a GitHub Action that runs gallery against a list of notable projects #1390

ambv opened this issue May 8, 2020 · 2 comments · Fixed by #2725
Assignees
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases T: enhancement New feature or request

Comments

@ambv
Copy link
Collaborator

ambv commented May 8, 2020

We should be running gallery against a list of notable projects in a GitHub Action on any commit and any pull request.

A commit to master

It should run black twice: using the latest released version and the current master; and diff the codebases. This will allow us to identify which commit introduces some weird and unwanted formatting behavior.

A pull request

The GitHub action should also run on all PRs too but it needs to compare current master versus current PR instead of latest released version versus current master.

Note

We cannot make the GitHub action "fail" because whether a formatting change is desired or not is in the eye of the beholder.

@ambv ambv added the T: enhancement New feature or request label May 8, 2020
@cooperlees cooperlees self-assigned this May 18, 2020
@cooperlees
Copy link
Collaborator

So I've started on this - I've wrote a tool black-primer that will run whatever black is in PATH in parallel at a level the runner can configure.

This will enable us to run with Current Master then compare with stable / latest release on CI by uninstalling the editable / TOT version and pip install black ...

Once a few more people have played with the tool I'll look to get a PR up to add this into our CI runs unless someone beats me. Docs and code itself are up and linked here.

@ichard26

This comment has been minimized.

@JelleZijlstra JelleZijlstra added the C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases label May 30, 2021
@ichard26 ichard26 self-assigned this Oct 22, 2021
@ichard26 ichard26 added this to the Release 22.0 milestone Dec 12, 2021
@ichard26 ichard26 removed this from the Release 22.0 milestone Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases T: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants