Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects using black #1956

Closed
RHammond2 opened this issue Feb 2, 2021 · 6 comments · Fixed by #2792
Closed

Projects using black #1956

RHammond2 opened this issue Feb 2, 2021 · 6 comments · Fixed by #2792
Labels
S: awaiting response Waiting for futher information from OP T: documentation Improvements to the docs (e.g. new topic, correction, etc)

Comments

@RHammond2
Copy link
Contributor

I couldn't really find anywhere else to put this, with there being no contact information, so hopefully this isn't in the way. If this is totally the wrong place, feel free to close it down.

For projects using Black, there are two (and soon a third) projects within the public facing National Renewable Energy Laboratory (NREL) GitHub repository that will be using black in a pre-commit framework for automatic code formatting. The first project and the third (not yet integrated, but working on it) are both fairly major projects within the wind energy modeling space. I figured I'd let you all know given you have a comment in your readme about that.

  1. FLORIS - wind farm wake modelling
  2. ORBIT - wind farm installation simulation tool for cost assessments
  3. OpenOA - SCADA data processing and analysis tool (not yet integrated, but am working on it)
@ichard26 ichard26 added the T: documentation Improvements to the docs (e.g. new topic, correction, etc) label Feb 2, 2021
@cooperlees
Copy link
Collaborator

Awesome. Feel free to do the PR to add it to the README.md if that's your goal here.

@ichard26
Copy link
Collaborator

ichard26 commented Feb 2, 2021

Oh how lovely! We actually have a section perfect for this: https://github.com/psf/black#used-by

If you don't mind, you can send in a PR. Don't worry, I can always pick up on the tab if you don't want to or can't.

@ichard26
Copy link
Collaborator

ichard26 commented Feb 2, 2021

of course me and cooper have to walk on top of each other's toes :D

@RHammond2
Copy link
Contributor Author

RHammond2 commented Feb 2, 2021

Thank you both! I'll put together a PR for this, but might hold off until I get the third project integrated (sometime over the next few weeks) to avoid multiple PRs now that I know that's the best way to do this.

Thanks for all your work on this project, I very much so appreciate it!

Feel free to close this as well as you see fit.

@ichard26 ichard26 added the S: awaiting response Waiting for futher information from OP label Dec 12, 2021
@ichard26
Copy link
Collaborator

Hi @RHammond2, what's the status on this? It's been a quite while :)

@RHammond2
Copy link
Contributor Author

This is my fault, I've quite swamped and let this slide. I'm going to submit a PR now so I don't forget again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: awaiting response Waiting for futher information from OP T: documentation Improvements to the docs (e.g. new topic, correction, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@cooperlees @RHammond2 @ichard26 and others